Messages in this thread | | | From | Paul Mackerras <> | Date | Sun, 26 May 2002 21:42:00 +1000 (EST) | Subject | Re: Linux 2.5.18-dj1 |
| |
Russell King writes:
> This oops has existed over several 2.5 versions. The following was thrown > around to fix it (I don't remember who though). > > --- orig/drivers/video/fbcmap.c Fri May 3 11:12:44 2002 > +++ linux/drivers/video/fbcmap.c Fri May 10 19:39:38 2002 > @@ -150,9 +150,9 @@ > else > tooff = from->start-to->start; > size = to->len-tooff; > - if (size > from->len-fromoff) > + if (size > (int)(from->len-fromoff)) > size = from->len-fromoff; > - if (size < 0) > + if (size <= 0) > return; > size *= sizeof(u16);
That looks like my patch. It stops the oops (by fixing a signed vs. unsigned comparison bug) but doesn't fix the colormap handling. On my G4 powerbook, which has an ATI Rage 128 (Mobility M3 AGP 2x) the screen colours are all totally wrong under X when I boot 2.5.18. I have Option "UseFBDev" in my /etc/X11/XF86Config-4, so the X server is using the kernel frame buffer driver to do colormap updates. (The colours are all OK on the text consoles though.)
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |