Messages in this thread Patch in this message | | | Date | Sat, 25 May 2002 10:53:42 -0500 (CDT) | From | Kai Germaschewski <> | Subject | Re: matroxfb & 2.5.18 BK: unresolved symbols in modules |
| |
On Sat, 25 May 2002, Meelis Roos wrote:
> Matroxfb as module: > > depmod: *** Unresolved symbols in /lib/modules/2.5.18/kernel/drivers/video/matrox/matroxfb_DAC1064.o > depmod: matrox_init_putc > depmod: *** Unresolved symbols in /lib/modules/2.5.18/kernel/drivers/video/matrox/matroxfb_Ti3026.o > depmod: matrox_init_putc > depmod: *** Unresolved symbols in /lib/modules/2.5.18/kernel/drivers/video/matrox/matroxfb_base.o > depmod: matrox_text_round > depmod: matrox_cfbX_init > depmod: initMatrox
matroxfb still relied on implicitly exporting all symbols. Seems I overlooked it before making exporting no symbols default, sorry. This patch will fix it.
--Kai
===== drivers/video/matrox/matroxfb_accel.c 1.4 vs edited ===== --- 1.4/drivers/video/matrox/matroxfb_accel.c Tue Feb 5 01:52:39 2002 +++ edited/drivers/video/matrox/matroxfb_accel.c Sat May 25 10:38:11 2002 @@ -143,6 +143,8 @@ ACCESS_FBINFO(accel.m_opmode) = mopmode; } +EXPORT_SYMBOL(matrox_cfbX_init); + static void matrox_cfbX_bmove(struct display* p, int sy, int sx, int dy, int dx, int height, int width) { int pixx = p->var.xres_virtual, start, end; CRITFLAGS @@ -943,7 +945,7 @@ CRITEND } -void matrox_text_createcursor(WPMINFO struct display* p) { +static void matrox_text_createcursor(WPMINFO struct display* p) { CRITFLAGS if (ACCESS_FBINFO(currcon_display) != p) @@ -1029,6 +1031,8 @@ var->xres_virtual = vxres * hf; } +EXPORT_SYMBOL(matrox_text_round); + static int matrox_text_setfont(struct display* p, int width, int height) { DBG("matrox_text_setfont"); @@ -1223,6 +1227,8 @@ } } +EXPORT_SYMBOL(initMatrox); + void matrox_init_putc(WPMINFO struct display* p, void (*dac_createcursor)(WPMINFO struct display* p)) { int i; @@ -1245,4 +1251,7 @@ ACCESS_FBINFO(curr.putcs) = matrox_cfbX_putcs; } } + +EXPORT_SYMBOL(matrox_init_putc); + MODULE_LICENSE("GPL"); ===== drivers/video/matrox/matroxfb_accel.h 1.1 vs edited ===== --- 1.1/drivers/video/matrox/matroxfb_accel.h Tue Feb 5 11:40:16 2002 +++ edited/drivers/video/matrox/matroxfb_accel.h Sat May 25 10:37:33 2002 @@ -5,7 +5,6 @@ void matrox_init_putc(WPMINFO struct display* p, void (*)(WPMINFO struct display *p)); void matrox_cfbX_init(WPMINFO struct display* p); -void matrox_text_createcursor(WPMINFO struct display* p); void matrox_text_round(CPMINFO struct fb_var_screeninfo* var, struct display* p); void initMatrox(WPMINFO struct display* p); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |