lkml.org 
[lkml]   [2002]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[RFC] change of ->bd_op->open() semantics
	Folks, I propose to cache the result of blk_get_queue() in
struct block_device upon ->open().

We already have struct block_device * whenever we are looking for
a queue. So the only real problem arises if value of blk_get_queue()
changes while device is opened. AFAICS nothing in the kernel pulls
such tricks (and to support them we would need to take care of a lot
of things, so changing the cached value wouldn't be a problem anyway).

Yes, it means updating every instance of ->open() for block
devices. All 30-odd of them. I can do that in a single pass - changes
are trivial.

It has an additional benefit of killing the array of default
queues on the same pass - a thing we will need to do sooner or later
anyway.

Does anybody see a problem with that?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.051 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site