Messages in this thread | | | Date | Fri, 24 May 2002 16:50:21 +0200 | From | Vojtech Pavlik <> | Subject | Re: [patch] New driver for Artop [Acard] controllers. |
| |
On Fri, May 24, 2002 at 04:29:39PM +0200, Bartlomiej Zolnierkiewicz wrote: > Hi! > > I have a very quick look over patch/driver... looks quite ok... > > But it doesn't support multiple controllers.
Yes, right! That's a bug. Ahh, that's why all the drivers use the PCI device id over and over and over in the sources ...
> We should add 'unsigned long private' to 'ata_channel struct' and > store index in the chipset table there.
That'd be great. Though I prefer void*. Looks like "drive_data" is intended for that purpose. Martin: How about renaming this to "private" and a comment "solely for use by chip-specific drivers"?
A private member in the ata_pci_device[] struct would be also very useful. Or is the "extra" field for that?
> You can remove duplicate entries from module data table.
I wonder how they got there ...
> BTW: please don't touch pdc202xx.c I am playing with it...
Ok, I won't. Send it to me for comments later.
-- Vojtech Pavlik SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |