lkml.org 
[lkml]   [2002]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] duplicate clock calculation code in 3 IDE drivers
Uz.ytkownik Vojtech Pavlik napisa?:
> On Wed, May 22, 2002 at 01:30:13PM +0400, Andrey Panin wrote:
>
>>Hi,
>>
>>now it is more interesting patch. AMD, PIIX and VIA IDE drivers contain
>>some duplicated code for (amd|piix|via)_clock calculation. Attached
>>patch moves this code into one function in ata-timing.c file.
>>
>>Please take a look at it.
>
>
> Looks quite OK - though it'd be better if "system_bus_speed" already
> could be giving these reasonable values - this way we could get rid of
> the (amd|piix|via)_clock variables altogether.


Yes indeed this would be the "kings road".

Any one of you who cares enough?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:26    [W:0.035 / U:1.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site