lkml.org 
[lkml]   [2002]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Serverworks IDE driver: missing static
Hi,

svwks_tune_chipset() function contains 3 arrays which IMHO should be static.
Attached patch fixed it, saving for me 48 bytes of code :))
Compiles, but untested. Please consider applying.

Best regards.

--
Andrey Panin | Embedded systems software engineer
pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.netdiff -urN -X /usr/share/dontdiff linux.vanilla/drivers/ide/serverworks.c linux/drivers/ide/serverworks.c
--- linux.vanilla/drivers/ide/serverworks.c Tue May 21 01:55:59 2002
+++ linux/drivers/ide/serverworks.c Wed May 22 03:36:04 2002
@@ -242,9 +242,9 @@

static int svwks_tune_chipset(struct ata_device *drive, byte speed)
{
- byte udma_modes[] = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05 };
- byte dma_modes[] = { 0x77, 0x21, 0x20 };
- byte pio_modes[] = { 0x5d, 0x47, 0x34, 0x22, 0x20 };
+ static byte udma_modes[] = { 0x00, 0x01, 0x02, 0x03, 0x04, 0x05 };
+ static byte dma_modes[] = { 0x77, 0x21, 0x20 };
+ static byte pio_modes[] = { 0x5d, 0x47, 0x34, 0x22, 0x20 };

struct ata_channel *hwif = drive->channel;
struct pci_dev *dev = hwif->pci_dev;[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 13:26    [from the cache]
©2003-2011 Jasper Spaans