lkml.org 
[lkml]   [2002]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [RFC][PATCH] TIMER_BH-less smptimers

Hi Dipankar,

> I have been experimenting with Ingo's smptimers and I ended up
> extending it a little bit. I would really appreciate comments
> on whether these things make sense or not.

I tried it out and found that we were context switching like crazy.
It seems we were always running the timers out of a tasklet because
we never unlocked the net_bh_lock.

Anton

diff -urN linux-2.5_smptimers/kernel/timer.c linux-2.5_tux/kernel/timer.c
--- linux-2.5_smptimers/kernel/timer.c Mon May 20 18:48:18 2002
+++ linux-2.5_tux/kernel/timer.c Mon May 20 18:41:32 2002
@@ -694,6 +694,7 @@
__run_timers(base);

hardirq_endlock(cpu);
+ spin_unlock(&net_bh_lock);
spin_unlock(&global_bh_lock);
return;
resched_net:
@@ -733,6 +734,7 @@
__run_timers(base);

hardirq_endlock(cpu);
+ spin_unlock(&net_bh_lock);
spin_unlock(&global_bh_lock);
local_irq_enable();
local_bh_enable();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.061 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site