lkml.org 
[lkml]   [2002]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 6/15] larger b_size, and misc fixlets
Andreas Dilger wrote:
>
> On May 19, 2002 12:39 -0700, Andrew Morton wrote:
> > - make the printk in buffer_io_error() sector_t-aware.
> > =====================================
> > --- 2.5.16/fs/buffer.c~sector_t-printing Sun May 19 11:49:47 2002
> > +++ 2.5.16-akpm/fs/buffer.c Sun May 19 12:02:57 2002
> > @@ -179,8 +179,8 @@ __clear_page_buffers(struct page *page)
> >
> > static void buffer_io_error(struct buffer_head *bh)
> > {
> > - printk(KERN_ERR "Buffer I/O error on device %s, logical block %ld\n",
> > - bdevname(bh->b_bdev), bh->b_blocknr);
> > + printk(KERN_ERR "Buffer I/O error on device %s, logical block %Ld\n",
> > + bdevname(bh->b_bdev), (u64)bh->b_blocknr);
> > }
>
> Not that I'm a 64-bit system user/developer, but it is my understanding
> that u64 == long on a 64-bit platform, so your cast to u64 does not
> actually change the type of b_blocknr as far as printk is concerned.
> You would need to cast it to unsigned long long instead.
>

Yes, I suppose so. That more closely matches what "%L" does.

-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.051 / U:8.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site