Messages in this thread | | | Date | Fri, 17 May 2002 12:47:31 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [PATCH] Fix BUG macro |
| |
On Fri, 17 May 2002, Rusty Russell wrote: > In message <Pine.LNX.4.21.0205170839240.1369-100000@localhost.localdomain> you > write: > > On Fri, 17 May 2002, Rusty Russell wrote: > > > > > > Um, show me where sizeof(KBUILD_BASENAME) + sizeof(__FUNCTION__) > > > > sizeof(__FILENAME__). > > > > If you're talking about kbuild2.5 > > No. It's the include files, which makes up the majority of strings.
If they do make up the majority of strings, that's partly because you don't have Andrew's out_of_line_bug work in your tree, partly because your linker isn't combining strings (mine neither, does any?), partly because (I suspect) you're overlooking the vast number of BUG __FILE__ strings which are just leafnames, to each of which you're now proposing to add one or more __FUNCTION__ strings.
And note that __LINE__ number is of __FILE__, not of KBUILD_BASENAME, nor of __FUNCTION__; so __INCLUDE_LEVEL__ may be necessary to make sensible messages (if you insist on proceeding without out_of_line_bug: which Andrew didn't push to Linus, in belief that a string-combining linker is on the way).
> See reply to Andrew Morton.
I did see your exchanges with Andrew, but you don't seem to be understanding one another, so I'm trying to be more explicit.
__HUGH__
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |