lkml.org 
[lkml]   [2002]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Strange s390 code in 2.4.19-pre8
> Date: Mon, 13 May 2002 11:18:22 -0500 (CDT)
> From: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>

> > The old Makefile was correct, and the only failing was a namespace
> > conflict between your fsm.c and fsm.c in ISDN, when CONFIG_MODVERSIONS
> > are used. The right fix is to rename your fsm.c or to create
> > fsm_s390_ksyms.c with all EXPORT_SYMBOL's sitting in there.
> > It is fixed in 2.5 with $(MODPREFIX) in Rules.make.
>
> It's easily possible to backport the 2.5 Rules.make change to 2.4, so the
> file doesn't have to be renamed - if you want me to do that, let me know.

Keith said to rename such things. Another easy thing to do
would be to move EXPORT_SYMBOL into s390_ksyms.c, under
#ifdef CONFIG_FSM_something. I understand that renaming
creates a diff with 100% change, so damage can easily
be slipped in, and then it's a hell to investigate.
[Let's see if a well known persona uses it as an excuse
for more commercial advertising of a certain software product].

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:26    [W:0.062 / U:4.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site