lkml.org 
[lkml]   [2002]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] 2.5.1[345]-dj Add cpqarray_init() back into genhd.c
Date
On Mon, 13 May 2002 22:03:34 -0400, 
Adam Kropelin <akropel1@rochester.rr.com> wrote:
>In 2.5.13-dj1, the call to cpqarray_init() in drivers/block/genhd.c was
>dropped. I'm not sure what the intent was since the driver seems to work fine
>as a module. In case it was a mistake, here's a patch (against 2.5.15-dj1) to
>add it back in. Without it, cpqarray only works as a module. Works For Me (tm).
>
>--Adam
>
>--- linux-2.5.15-dj1-virgin/drivers/block/genhd.c Mon May 13 21:21:59 2002
>+++ linux-2.5.15-dj1/drivers/block/genhd.c Mon May 13 21:18:48 2002
>@@ -229,6 +229,9 @@
> /* This has to be done before scsi_dev_init */
> soc_probe();
> #endif
>+#ifdef CONFIG_BLK_CPQ_DA
>+ cpqarray_init();
>+#endif
> #ifdef CONFIG_NET
> net_dev_init();
> #endif

The real problem appears to be cpqarray.c, it wraps the init/exit code
in #ifdef MODULE, so the init code is only available to modules. I
think that cpqarray.c should remove the #ifdef MODULE and use the same
init mechanism as other drivers, including module_init/exit. I don't
have a card and the code is a mess so I am not going to attempt a patch.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:26    [W:0.052 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site