lkml.org 
[lkml]   [2002]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectOverlapping MTRRs
Questions, and answer.

First: Is it true what I here that MTRRs are getting a complete overhaul
for 2.5? If so, I'll probably just quit where I'm at now.

Anyway, I've got vesafb creating a WC MTRR at 0xf9000000, size 0x200000.
Then X goes and tries to create another (same type) at xf9000000 with
size 0x400000. With the standard code, it fails.

It looks to me that the code that's there was *supposed* to handle such
simple overlap cases, but it kinda doesn't.

So I wrote a patch for handling MTRRs. It's way oversimplified, but it
does the right thing in quite a few simple cases, so it might help some
other people who've got a problem similar to mine.

It has some limitations, especially, that it doesn't do any magic on
removes. I've been thinking on how to do this "right", and although it's
not *too* complicated, it's pretty hard anyway. I might try it, but if
someone else is working on it, I'll trust them over me. I'm no real
kernel hacker. ;)

Anyway, patch is inlined after the message. You probably want to apply
it with -p1. It should apply cleanly on all recent 2.4. It comes up with
30some lines of offset on 2.4.19pre7ac4 (which I'm running now), but
it's harmless.

--Andrew ("hobbs" on IRC) Rodland

P.S. I sent this to rgooch a while back, and got no reply. Dunno whether
he hated it or he was just busy, but I'm lettin' the world know this
time.


--- linux/arch/i386/kernel/mtrr.c Fri Nov 9 16:58:02 2001
+++ linux-2.4.18+hobbs/arch/i386/kernel/mtrr.c Sat Mar 9 23:12:18 2002
@@ -1222,8 +1222,11 @@
[NOTE] This routine uses a spinlock.
*/
int i, max;
+ int ret;
mtrr_type ltype;
unsigned long lbase, lsize, last;
+
+

switch ( mtrr_if )
{
@@ -1337,7 +1340,27 @@
printk (KERN_WARNING "mtrr: 0x%lx000,0x%lx000 overlaps
existing" " 0x%lx000,0x%lx000\n",
base, size, lbase, lsize);
- return -EINVAL;
+ if ( type == ltype ) {
+ ret=-42;
+ if (base < lbase) {
+ printk (KERN_INFO "mtrr: creating new
0x%lx000,0x%lx000\n",base,lbase-base);+
ret=mtrr_add_page(base, lbase-base, type, 0);+ }
+ if (base + size > lbase + lsize) {
+ printk (KERN_INFO "mtrr: creating new
0x%lx000,0x%lx000\n",lbase+lsize,base+size-lbase-lsize);+
ret=mtrr_add_page(lbase+lsize,base+size-lbase-lsize, type, 0);+
}+ if (ret == -42) {
+ printk (KERN_INFO "mtrr: it must have been
contained.\n");+ return i;
+ }
+ /* Okay, so it DID create a new one. */
+ return ret;
+ } else {
+ printk (KERN_WARNING "mtrr: type mismatch (old: %s new: %s),
giving up.\n",+ attrib_to_str(ltype),attrib_to_str(type));
+ return -EINVAL;
+ }
}
/* New region is enclosed by an existing region */
if (ltype != type)
[unhandled content-type:application/pgp-signature][unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 13:26    [W:0.022 / U:1.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site