Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [RFC] Some useless cleanup | Date | Sun, 12 May 2002 22:09:54 +1000 |
| |
In message <20020509222358.GB8651@codepoet.org> you write: > On Thu May 09, 2002 at 10:36:50PM +1000, Rusty Russell wrote: > > Um, why not simply: > > > > static inline void set_name(struct task_struct *tsk, const char *name) > > { > > /* comm is always nul-terminated already */ > > strncpy(tsk->comm, name, sizeof(tsk->comm)-1); > > } > > > > Your implementation using snprintf is (wasteful and) dangerous, > > Rusty. > > And both implementations suffer from the fact that if tsk->comm > were to change from a fixed length array to a char*, allowing > arbitrarily sized names, you would end up copying very little > indeed. :)
Um, yes, if someone were to make a random change to the kernel without looking at what it would effect, the kernel would likely break.
Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |