Messages in this thread | | | Date | Sun, 12 May 2002 20:36:25 -0600 | From | Richard Gooch <> | Subject | Re: [PATCH] devfs v212 available |
| |
Alexander Viro writes: > On Sat, 11 May 2002, Richard Gooch wrote: > > This is against 2.5.14. Highlights of this release: > > > > - Added BKL to <devfs_open> because drivers still need it > > Sigh... Look at the callers of check_disc_changed() and check > what's going on with traversing directory contents there.
OK, I've had a look. There is indeed a race there. While it is safe against module unloading, it isn't safe against removal of entries from the directory. I'm considering some different options to fix this (one is simple and obvious, the other will be a little more efficient).
Question: can invalidate_device() and the bdops methods check_media_change() and revalidate() be called with a lock held?
Regards,
Richard.... Permanent: rgooch@atnf.csiro.au Current: rgooch@ras.ucalgary.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |