lkml.org 
[lkml]   [2002]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] reworked IDE/general tagged command queueing
On Wed, May 01 2002, Martin Dalecki wrote:
> >Well after a short cross over look at it I agree.
> >The generic interface looks sane for me as well. However
> >I will have to look a bit deeper, becouse at the first sight
> >the double pointer to tag_index looks a bit "overelaborate"
> >to me. But I may change my opinnion after looking at the
> >actual usage - so please take this small bit of critique
> >with a good grain of salt...
> >
> >+#define BLK_TAGS_PER_LONG (sizeof(unsigned long) * 8)
> >+#define BLK_TAGS_MASK (BLK_TAGS_PER_LONG - 1)
> >+
> >+struct blk_queue_tag {
> >+ struct request **tag_index; /* map of busy tags */
> >+ unsigned long *tag_map; /* bit map of free/busy tags */
> >+ struct list_head busy_list; /* fifo list of busy tags */
> >+ int busy; /* current depth */
> >+ int max_depth;
> >+};
> >+
>
> Well I revoke my objections. tag_index is fine :-).

It should be, it's just an index of pointer to request, so no double
indirections :)

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:25    [W:0.058 / U:7.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site