lkml.org 
[lkml]   [2002]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5.10 IDE 42
    Hi!

    > @@ -783,16 +771,23 @@
    > if (stat & BUSY_STAT)
    > printk("Busy ");
    > else {
    > - if (stat & READY_STAT) printk("DriveReady ");
    > - if (stat & WRERR_STAT) printk("DeviceFault ");
    > - if (stat & SEEK_STAT) printk("SeekComplete ");
    > - if (stat & DRQ_STAT) printk("DataRequest ");
    > - if (stat & ECC_STAT) printk("CorrectedError ");
    > - if (stat & INDEX_STAT) printk("Index ");
    > - if (stat & ERR_STAT) printk("Error ");
    > + if (stat & READY_STAT)
    > + printk("DriveReady ");
    > + if (stat & WRERR_STAT)
    > + printk("DeviceFault ");
    > + if (stat & SEEK_STAT)
    > + printk("SeekComplete ");
    > + if (stat & DRQ_STAT)
    > + printk("DataRequest ");
    > + if (stat & ECC_STAT)
    > + printk("CorrectedError ");
    > + if (stat & INDEX_STAT)
    > + printk("Index ");
    > + if (stat & ERR_STAT)
    > + printk("Error ");
    > }
    > printk("}");
    > -#endif /* FANCY_STATUS_DUMPS */
    > +#endif
    > printk("\n");
    > if ((stat & (BUSY_STAT|ERR_STAT)) == ERR_STAT) {
    > err = GET_ERR();

    I believe this is actually making it *less* readable.

    > @@ -839,7 +834,7 @@
    > printk(", sector=%ld", HWGROUP(drive)->rq->sector);
    > }
    > }
    > -#endif /* FANCY_STATUS_DUMPS */
    > +#endif
    > printk("\n");
    > }
    > __restore_flags (flags); /* local CPU only */

    Here to. Comment after endif is good thing; you don't have to add it
    but you should certainly not kill it.
    Pavel
    --
    (about SSSCA) "I don't say this lightly. However, I really think that the U.S.
    no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:25    [W:4.169 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site