Messages in this thread | | | Date | Fri, 26 Apr 2002 10:37:36 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] 2.5.10 IDE 42 |
| |
On Fri, 26 Apr 2002, Pavel Machek wrote: > > + if (stat & READY_STAT) > > + printk("DriveReady "); > > + if (stat & WRERR_STAT) > > + printk("DeviceFault "); > > + if (stat & SEEK_STAT) > > + printk("SeekComplete "); > > + if (stat & DRQ_STAT) > > + printk("DataRequest "); > > + if (stat & ECC_STAT) > > + printk("CorrectedError "); > > + if (stat & INDEX_STAT) > > + printk("Index "); > > + if (stat & ERR_STAT) > > + printk("Error "); > > I believe this is actually making it *less* readable.
Somewhat agreed. Also, the above is just not the right way to do printouts.
I'd suggest rewriting the whole big mess as something like
#define STAT_STR(x,s) \ ((stat & x ##_STAT) ? s " " : "")
...
printf("IDE: %s%s%s%s%s%s..\n" STAT_STR(READY, "DriveReady"), STAT_STR(WERR, "DeviceFault"), ...
which is pretty certain to generate much smaller code (not to mention smaller sources).
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |