lkml.org 
[lkml]   [2002]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH] TRIVIAL 2.4.19-pre7: smp_call_function not allowed from bh
From
   From: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon, 22 Apr 2002 13:35:34 +1000

It would be nice to fix this up on every other smp_call_function
implementation too. Since this patch is by definition trivial, it
would be equally trivial to make sure every platform is updated
properly as well.

Please do this before installing the change.

Thanks.

--- trivial-2.4.19-pre7/arch/i386/kernel/smp.c.orig Mon Apr 22 13:21:41 2002
+++ trivial-2.4.19-pre7/arch/i386/kernel/smp.c Mon Apr 22 13:21:41 2002
@@ -528,7 +528,7 @@
* remote CPUs are nearly ready to execute <<func>> or are or have executed.
*
* You must not call this function with disabled interrupts or from a
- * hardware interrupt handler, you may call it from a bottom half handler.
+ * hardware interrupt handler or from a bottom half handler.
*/
{
struct call_data_struct data;
@@ -544,7 +544,7 @@
if (wait)
atomic_set(&data.finished, 0);

- spin_lock_bh(&call_lock);
+ spin_lock(&call_lock);
call_data = &data;
wmb();
/* Send a message to all other CPUs and wait for them to respond */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.039 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site