Messages in this thread | | | From | Itai Nahshon <> | Subject | Re: [PATCH] Change "return EBLAH" to "return -EBLAH in drivers/* | Date | Wed, 17 Apr 2002 15:29:35 +0300 |
| |
On Wednesday 17 April 2002 07:42 am, Anthony J. Breeds-Taurima wrote: > --- linux-2.4.19-pre6.clean/drivers/net/plip.c Mon Oct 22 16:05:31 2001 > +++ linux-2.4.19-pre6/drivers/net/plip.c Wed Apr 17 11:08:35 2002 ... > - return ERROR; > + return -ERROR;
At least the changes to plip.c are wrong.
ERROR is not an errno value: #define ERROR 2 and the return from this function is propgated to a test if (error != ERROR) { /* Timeout */ Which will go wrong with the suggested patch.
-- Itai
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |