Messages in this thread | | | Subject | Re: [Patch] Compilation error on 2.5.8 | From | Robert Love <> | Date | 15 Apr 2002 19:24:29 -0400 |
| |
On Mon, 2002-04-15 at 19:34, Bongani wrote:
> Does this also look cleaner ?
> -static inline void setup_per_cpu_areas(void) > -{ > -} > + > +#define setup_per_cpu_areas() do { } while(0) > +
Personally yes, but others would disagree.
In fact, if we use a define setup_per_cpu_areas can not be used outside of this compilation unit. Right now this looks to be the case, but if something other than init/main.c wanted to use setup_per_cpu_areas we would need to make the code an actual function or put the define in a header file.
Since either case should optimize away, maybe we should make it a static inline in both cases, since that is the authors original preference ...
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |