lkml.org 
[lkml]   [2002]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] for_each_zone / for_each_pgdat

    On Mon, 15 Apr 2002, Rik van Riel wrote:
    > replace slightly obscure while loops with for_each_zone and
    > for_each_pgdat macros, this version has the added optimisation
    > of skipping empty zones (thanks to William Lee Irwin)

    I'd suggest against making this kind of complicated inlien functions, and
    I also don't see why the for_each_zone() isn't a simpler doubly nested
    for-loop instead of being forced into a less obvious iterative loop?

    In short, this looks syntactically simple, but the syntactic simplicity
    comes at the expense of a unnecessarily complex implementation.

    Linus

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:25    [W:0.042 / U:29.584 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site