Messages in this thread | | | Subject | Re: [bkpatch] do_mmap cleanup | From | Juan Quintela <> | Date | 09 Mar 2002 03:15:38 +0100 |
| |
>>>>> "benjamin" == Benjamin LaHaise <bcrl@redhat.com> writes:
benjamin> diff -Nru a/include/linux/mm.h b/include/linux/mm.h benjamin> --- a/include/linux/mm.h Fri Mar 8 18:46:34 2002 benjamin> +++ b/include/linux/mm.h Fri Mar 8 18:46:34 2002 benjamin> @@ -492,20 +492,11 @@ benjamin> extern int do_munmap(struct mm_struct *, unsigned long, size_t); benjamin> +extern long sys_munmap(unsigned long, size_t);
Please, don't do that, export another function that does exactly that. sys_munmap is declared as asmlinkage, and some architectures (at least ppc used to have) need especial code to be able to call asmlinkage functions from inside the kernel.
Declaring a __sys_munmap() that does the work and is exported and then sys_munmap to be only the syscall entry is better.
asmlinkage long sys_munmap(unsigned long addr, size_t len)
Later, Juan.
-- In theory, practice and theory are the same, but in practice they are different -- Larry McVoy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |