lkml.org 
[lkml]   [2002]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] Patch to pull NFS server address off root_server_path
From
Date
>>>>> " " == Rusty Russell <rusty@rustcorp.com.au> writes:

> This patch was submitted to the trivial patch daemon. Looks OK
> to me, Trond?

> --- linux.orig/net/ipv4/ipconfig.c Tue Feb 26 07:14:51 2002
> +++ linux/net/ipv4/ipconfig.c Wed Mar 6 14:01:10 2002
> @@ -1197,6 +1197,16 @@
> ic_dev = ic_first_dev->dev;
> }

> +#ifdef CONFIG_ROOT_NFS
> + {
> + extern void __init root_nfs_parse_addr(char *name, u32
> *addr);
> + u32 addr = INADDR_NONE;
> + root_nfs_parse_addr(root_server_path, &addr);
> + if (root_server_addr == INADDR_NONE)
> + root_server_addr = addr;
> + }
> +#endif +
Erm... Is this __init declaration here correct?

Wouldn't it really be better to move root_nfs_parse_addr() into the
ipconfig code? Since, CONFIG_ROOT_NFS depends on CONFIG_IP_PNP being
set, you could also get rid of your #ifdef above...

Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.027 / U:3.400 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site