lkml.org 
[lkml]   [2002]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] IBM Lanstreamer bugfixes (round 3)
David Dillow wrote:
>
> Jeff Garzik wrote:
> >
> > David Dillow wrote:
> > >
> > > Jeff Garzik wrote:
> > > > Set cache line size just like drivers/net/acenic.c does, and enable
> > > > memory-write-invalidate...
> > >
> > > Does this mean the setup pci_enable_device() does on the cache line size
> > > is not sufficient?
> >
> > pci_enable_device doesn't touch the PCI_COMMAND_INVALIDATE bit at all...
>
> Right, I was talking more about the cache line size... is it sufficient
> for that?

pci_enable_device doesn't touch PCI_COMMAND_INVALIDATE either, on most
platforms (particularly ia32, i.e. the popular one :))


> As for PCI_COMMAND_INVALIDATE, what does that do for me; my PCI spec
> isn't handy....

Enables Memory-Write-Invalidate (MWI).


> > > I ask, because I've been relying on it for a driver I'm working on;
> > > should I be setting this as acenic does? It would seem that this is
> > > something many drivers would need to do...
> >
> > Yes, acenic is the code to copy, for setting that up.
>
> INVALIDATE, or cache line size?

both.

Jeff



--
Jeff Garzik |
Building 1024 |
MandrakeSoft | Choose life.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.110 / U:0.524 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site