[lkml]   [2002]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] 3c59x and resume

Here is a small patch tested with 2.4.18 and 2.4.19-pre4.
It was proposed by Andrew but not integrated in pre4.

The problem is when using the vortex driver and suspend/resuming the
machine. Without this patch the card id is each time greater. To resume
correctly this driver need the option enable_wol=1 but as-is it will
only be true for the first ID. You can enable it for the first 8 IDs
with enable_wol=1,1,1,1,1,1,1,1 but you can't do it for all IDs.
Said another way without this patch you can't suspend/resume more than
eight times your machine.

This is a fix for the most common use. The proper fix would be IMO to
keep a bitmap of used IDs but I don't know if it worsts it.
Also a fix would be to separate the suspend/resume functionality from
the wol functionality (wake up on lan).


--- linux/drivers/net/3c59x.c Sat Mar 23 10:24:56 2002
+++ linux/drivers/net/3c59x.c Sat Mar 23 10:57:00 2002
@@ -2891,6 +2891,9 @@

vp = dev->priv;

+ if (vp->card_idx == vortex_cards_found - 1)
+ vortex_cards_found--;
/* AKPM: FIXME: we should have
* if (vp->cb_fn_base) iounmap(vp->cb_fn_base);
* here
Christophe Barbé <>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8 F67A 8F45 2F1E D72C B41E

There's no sense in being precise when you don't even know what you're
talking about. -- John von Neumann
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2005-03-22 13:25    [W:0.200 / U:1.572 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site