Messages in this thread | | | Date | Thu, 21 Mar 2002 17:27:55 -0800 | From | Patrick Mansfield <> | Subject | Re: 2 questions about SCSI initialization |
| |
On Thu, Mar 21, 2002 at 07:04:51PM -0500, Pete Zaitcev wrote: > > Date: Thu, 21 Mar 2002 14:26:35 -0800 > > From: Patrick Mansfield <patmans@us.ibm.com> > > --- scsi.c.orig Thu Mar 21 13:51:27 2002 > > +++ scsi.c Thu Mar 21 13:52:54 2002 > > @@ -2331,8 +2331,8 @@ > > /* > > * If we are busy, this is not going to fly. > > */ > > - if (GET_USE_COUNT(tpnt->module) != 0) > > - goto error_out; > > + if (tpnt->module && (GET_USE_COUNT(tpnt->module) != 0)) > > + BUG(); > > Guaranteed to trigger BUG() is out_of_memory gets set. > > I still think we better kill this check altogether. > Any more objections?
No objection.
The same problem exists in scsi_unregister_host, where it checks GET_USE_COUNT(SDpnt->host->hostt->module). It looks like we would hit this with sd and scsi built into the kernel, and an insmod of an adapter that hits a scsi_build_commandblocks failure. Correct?
-- Patrick Mansfield
> > -- Pete > - > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |