Messages in this thread | | | Subject | Re: aa-160-lru_release_check | From | Robert Love <> | Date | 20 Mar 2002 15:42:38 -0500 |
| |
On Wed, 2002-03-20 at 14:28, Andrew Morton wrote:
> I hate BUG_ON() :) It's arse-about so you have to stare at it furiously > to understand why your kernel still works. > > I hope the Nobel committee is reading this mailing list: how > about assert()?
I have a patch that introduces BUG_ON for 2.4. I like the idea of BUG_ON and it is certainly a place where the unlikely bit is useful. I've posted the patch here before; I was going to do so again against the next 2.4-pre.
Further, and most importantly, the patch provides compatibility with 2.5 code that uses it. I have no problems naming BUG_ON anything anyone wants (Jeff's suggestion of kassert seems sane) but we should then do the proper renaming in 2.5.
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |