Messages in this thread | | | Date | Fri, 15 Mar 2002 14:06:04 -0800 | From | Stephen Samuel <> | Subject | Re: [PATCH] syscall interface for cpu affinity |
| |
Picking nits, but....
Andreas Ferber wrote:
> Setting the affinity of a whole process group also makes sense IMHO. > Therefore I think an interface more like the setpriority syscall > for sched_set_affinity (with two parameters which/who instead of a > single PID) would be more flexible, eg. > > int sched_set_affinity(int which, int who, unsigned int len, > unsigned long *new_mask_ptr); > > with who one of {PRIO_PROCESS,PRIO_PGRP,PRIO_USER} and which according > to the value of who.
I soule suggest that the order be
int sched_set_affinity(int who, int which, unsigned int len, unsigned long *new_mask_ptr);
This would have the {p,pg}id be the first thing that a programmer would see (likely more important than the 'which'.).
-- Stephen Samuel +1(604)876-0426 samuel@bcgreen.com http://www.bcgreen.com/~samuel/ Powerful committed communication, reaching through fear, uncertainty and doubt to touch the jewel within each person and bring it to life.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |