Messages in this thread | | | From | "Adam J. Richter" <> | Date | Wed, 13 Mar 2002 09:17:52 -0800 | Subject | Re: linux-2.5.6 scsi DMA mapping and compilation fixes (not yet working) |
| |
>[...] A general give away that you have the right one is that >they are formatted to the linux CodingStyle document.
>Alan
Actually, there are many indentation changes between the NCR drivers in 2.4.18 and 2.5.6, but looking at the changes with "diff -w" shows very few other changes, just really ancilliary things like option parsing.
I was a little surprised to see things like procedure declaration lines ending in "{", which I understand confuses vi (or some vi's). Examples from g_NCR53C80.c include internal_setup, generic_NCR5380_setup, generic_NCR53C400_setup, and many others.
I believe the code in 2.5.6 is your new NCR driver, in spite of the formatting differences.
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104 adam@yggdrasil.com \ / San Jose, California 95129-1034 +1 408 261-6630 | g g d r a s i l United States of America fax +1 408 261-6631 "Free Software For The Rest Of Us." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |