lkml.org 
[lkml]   [2002]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: root-owned /proc/pid files for threaded apps?
On Fri, Mar 08, 2002 at 07:09:37PM -0800, Danek Duvall wrote:

> Ok, after trying all four combinations (call to wmb() moved or not, and
> set_user(0, 1) vs set_user(0, 0)), it turns out all four exhibit
> skipping, so that's unrelated (in fact, it seems to happen not on net
> access, but on redraw -- mozilla's dialogs make xmms skip, too).

OK, so it's clearly unrelated.

> I'll leave it for someone else to decide what arguments to set_user()
> exec_usermodehelper() should pass.

Clearing dumpable at this point is obviously wrong as it always has
side-effects on the process that was leading into the module request.

It's also unnecessary, as it /only/ has effect on the /old/ mm_struct,
before doing the execve() of the usermode helper. As request_module
and friends don't introduce sensitive data into the address space of
the calling process, leaving dumpable alone is just fine.

So, IMO, set_user(0, 0) should be the way to go.

Andreas
--
Andreas Ferber - dev/consulting GmbH - Bielefeld, FRG
---------------------------------------------------------
+49 521 1365800 - af@devcon.net - www.devcon.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.065 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site