Messages in this thread |  | | Date | Fri, 1 Mar 2002 08:14:10 +0100 | From | Erik Mouw <> | Subject | Re: read_proc issue |
| |
On Wed, Feb 27, 2002 at 04:19:35AM +0100, Daniel Phillips wrote: > On February 28, 2002 01:05 am, Erik Mouw wrote: > > It might also be an idea to export proc_calc_metrics() from > > fs/proc/proc_misc.c because quite a lot of code actually tries to do > > exactly the same. > > Look at all the parameters, they're trying to be a struct. How about > cleaning it up before exporting?
Look at all the parameters of a procfs read() function and compare them with the parameters of proc_calc_metrics(). See why cleaning up would make things only more complicated?
Erik
-- J.A.K. (Erik) Mouw, Information and Communication Theory Group, Faculty of Information Technology and Systems, Delft University of Technology, PO BOX 5031, 2600 GA Delft, The Netherlands Phone: +31-15-2783635 Fax: +31-15-2781843 Email: J.A.K.Mouw@its.tudelft.nl WWW: http://www-ict.its.tudelft.nl/~erik/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |