lkml.org 
[lkml]   [2002]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH/RFC] videodev.[ch] redesign
Date
On Saturday 09 February 2002 19:46, Gerd Knorr wrote:
> Hi,
>

> The patch below does part one of the plan -- for 2.4.x kernels. It adds
> the fops pointer to struct video_device and makes video_open use it if
> available, so both old + new style drivers will work.
>
> It also provides a ioctl wrapper function which handles copying the
> ioctl args from/to userspace, so we have this at one place can drop all
> the copy_from/to_user calls within the v4l device driver ioctl handlers.

That is a large improvement.
But you don't include a lock against reentry, which is bad.

> Comments?

Could you make a helper for open like for ioctl ?
And please don't use a pointer to the device descriptor
in the file structure. It makes live for USB devices much harder.

Regards
Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.134 / U:0.668 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site