lkml.org 
[lkml]   [2002]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: want opinions on possible glitch in 2.4 network error reporting
Andi Kleen wrote:
>
> Chris Friesen <cfriesen@nortelnetworks.com> writes:
>
> > I've been looking around in the 2.4 networking stack, and I noticed that when
> > the tulip (and no doubt many other) driver cannot put any more outgoing packets
> > on the queue, it calls netif_stop_queue(). Then, in dev_queue_xmit() we check
> > this flag by calling netif_queue_stopped(). My concern is that if this flag is
> > true, we return -ENETDOWN. Is this really the proper return code for this? If
> > anything, the network is too active. It seems to me that it would make more
> > sense to have some kind of congestion return code rather than claiming that the
> > network is down.
>
> The ENETDOWN path you're seeing only applies to queueless devices (like
> loopback or a tunnel device). These should only set the queued stopped
> flag when something is terrible wrong.
>
> All real network devices have a queue and go through the qdisc.

Okay, I must be missing something, so can you enlighten me? I can't figure out
where the qdisc is attached to the ethernet device.

Chris

--
Chris Friesen | MailStop: 043/33/F10
Nortel Networks | work: (613) 765-0557
3500 Carling Avenue | fax: (613) 765-2986
Nepean, ON K2H 8E9 Canada | email: cfriesen@nortelnetworks.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.038 / U:29.772 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site