Messages in this thread |  | | Date | Wed, 6 Feb 2002 19:11:08 +0100 | From | Dave Jones <> | Subject | Re: Fix for duplicate /proc entries |
| |
On Tue, Feb 05, 2002 at 09:52:55PM -0600, Brent Cook wrote:
> I think that I have found a problem with proc_dir_entry(). It seems to > allow multiple /proc entries to be created with the same name, without > returning a NULL pointer. I asked the folks on #kernelnewbies, and they > said that perhaps this is a feature. In either case, I believe that the > following patch fixes the issue by checking if a proc entry already exists > before creating it. This mirrors the behavior of remove_proc_entry, which > checks for the presense of a proc entry before deleting it.
The only instance I've seen of this happen is the acpi code. Whilst the patch is good in the sense that it allows things like /proc/acpi/button to become usable, the correct fix would be to fix ACPI.
Maybe printk'ing a "tried to create duplicate xxx proc entry" would be useful, so we at least don't paper over problems and make them harder to find later.
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |