lkml.org 
[lkml]   [2002]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.5.3] wavelan_cs.c : new WE api
Comments pertaining to all three of wavelan, wavelan_cs, and netwave_cs:
* wv_splhi should really just be spin_lock_irqsave. calling
spin_lock_irqsave with 'flags' from another function is non-portable.
doing so to an inline function is just barely portable, and is
discouraged :)
* I still see a couple save_flags/restore_flags in there...

otherwise looks ok to me.

--
Jeff Garzik | "I went through my candy like hot oatmeal
Building 1024 | through an internally-buttered weasel."
MandrakeSoft | - goats.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:23    [W:0.031 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site