Messages in this thread | | | Date | Sun, 3 Feb 2002 12:46:14 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] Generic HDLC patch for 2.5.3 |
| |
I like. This patch much improves things.
"SIOCDEVICE" as a constant is unacceptable, so it would need to be SIOCWANDEVICE or something similar.
SIOCETHTOOL, for example, is an ioctl which actually provides sub-ioctls, so that is probably a good model to follow.
More comments after I return from New York, and can review these at length...
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |