lkml.org 
[lkml]   [2002]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: read_proc issue
    Date
    On February 28, 2002 01:05 am, Erik Mouw wrote:
    > On Wed, Feb 27, 2002 at 09:42:04PM +0000, Alan Cox wrote:
    > > > I've encountered this problem before, too. What is the "One True Way"
    > > > to do this cleanly? In other words, if you want to do a calculation
    > > > once every time someone runs "cat /proc/foo", what is the cleanest way
    > > > to do that? The solution we came up with was to check the file offset
    > > > and only do the calculation if offset == 0, which seems pretty
    > > > hackish.
    > >
    > > Another approach is to do the calculation open and remember it in per
    > > fd private data. You can recover that and free it on release. It could
    > > even be a buffer holding the actual "content"
    >
    > It might also be an idea to export proc_calc_metrics() from
    > fs/proc/proc_misc.c because quite a lot of code actually tries to do
    > exactly the same.

    Look at all the parameters, they're trying to be a struct. How about
    cleaning it up before exporting?

    --
    Daniel
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:21    [W:0.025 / U:60.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site