[lkml]   [2002]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Quota & XFS patch
> On Wed, 27 Feb 2002, Jan Kara wrote:
> > Hello,
> >
> > I'm sending you Nathan's patch which implements things
> > in quotactl interface needed for XFS. If you can remember
> > the patch was already floating around some time
> > ago and was generally accepted... Please apply (it will
> > at least simplify patching of kernels for XFS).
> Why are you leaving some copy_from_user() in methods? Either the structures
> you are passing are fs-independent and everybody would be better off with
> having them copied in one place or they are not, and then API is completely
> broken.
Umm... I'm not sure I understand your objections - as I'm looking into the patch
all the copy_from_user() were moved from functions into sys_quotactl(). The
only thing you might not like is that XFS has extra structures and calls...
I don't like this too much either but XFS has different quota model so
creating common interface (structures) is a problem.

Thanks for comments

PS: Alan is not going to accept the patch anyway because he doesn't want further
interface differences between his and Linus's tree. But anyway discussion on this
topic is useful because I have similar patch for 2.5...

Jan Kara <>
SuSE CR Labs
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:24    [W:0.040 / U:10.792 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site