Messages in this thread | | | Date | Mon, 25 Feb 2002 18:46:12 -0800 | From | William Lee Irwin III <> | Subject | Re: [PATCH] struct page shrinkage |
| |
Rik van Riel wrote: >> >> + clear_bit(PG_locked, &p->flags);
On Mon, Feb 25, 2002 at 06:16:49PM -0800, Andrew Morton wrote: > Please don't do this. Please use the macros. If they're not > there, please create them. > > Bypassing the abstractions in this manner confounds people > who are implementing global locked-page accounting. > > In fact, I think I'll go rename all the page flags...
This is lingering context from the driver... it's ugly, I didn't go after cleaning that up when I had to touch this function because of the usual minimal-impact / only do one thing principle.
Perhaps others were similarly (un)motivated.
Cheers, Bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |