lkml.org 
[lkml]   [2002]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] struct page shrinkage
From
   From: Rik van Riel <riel@conectiva.com.br>
Date: Mon, 25 Feb 2002 22:57:38 -0300 (BRT)

On Mon, 25 Feb 2002, David S. Miller wrote:

> Please fix the atomic_t assumptions in init_page_count() first.
> You should be using atomic_set(...).

Why ? You'll see init_page_count() is _only_ used from
free_area_init_core(), when nothing else is using the VM
yet.

Rik, not every architecture has a "counter" member of
atomic_t, that is the problem. This is a hard bug, please
fix it. It is an opaque type, accessing its' implementation
directly is therefore illegal in the strongest way possible.

This exact same code has been in -rmap for a few months
and went into 2.5 just over a week ago. It doesn't seem
to give any problems ...

Because I haven't pushed my sparc64 changesets yet, I'm doing
that tonight.

Franks a lot,
David S. Miller
davem@redhat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:20    [W:0.071 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site