lkml.org 
[lkml]   [2002]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5.5-pre1 IDE cleanup 9
    Martin Dalecki wrote:
    > Will do soon. But now I don't have it at hand, it's on my home system
    > unfortunately and I would like to finish some other minor things there
    > as well. I mean basically the macro games showing that somebody didn't
    > understand C pointer semantics found at places like:
    >
    > #ifdef CONFIG_BLK_DEV_ALI15X3
    > extern unsigned int pci_init_ali15x3(struct pci_dev *, const char *);
    > ...
    > #define PCI_ALI15X3 &pci_init_ali15x3
    > #else
    > ...
    > #define PCI_ALI15X3 NULL
    > #endif
    >
    > This should rather look like:
    >
    > #ifdef CONFIG_BLK_DEV_ALI15X3
    > extern unsigned int pci_init_ali15x3(struct pci_dev *);
    > #else
    > #define pci_init_ali15x3 NULL
    > #endif

    For what the code is trying to accomplish, the code is correct.

    I agree the above change is also correct... probably the author wanted
    to reduce the size of the -huge- data table where PCI_ALI15X3 symbol is
    used.


    > And be replaces entierly by register_chipset(...) blah blah or
    > therlike ;-) as well as module initialization lists.

    When we have "modprobe piix4_ide" loading the IDE subsystem, you are
    correct.

    IDE is currently driven by an inward->outward setup of module
    initialization, which is fundamentally the opposite of what we want,
    which is chipset_drvr -> core initialization.

    Jeff



    --
    Jeff Garzik | "UNIX enhancements aren't."
    Building 1024 | -- says /usr/games/fortune
    MandrakeSoft |
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:24    [W:0.024 / U:30.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site