lkml.org 
[lkml]   [2002]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5.5 IDE cleanup 11
    > hum, I'm not sure that removing ->driver_init is a good idea.
    >
    > Seems like a loss of flexibility to me, not a cleanup, and I wonder if
    > you have thought through all the paths that wind up calling
    > ->driver_init.

    Yes I have tought it all through!
    Please trust me - I eat at least myself my dog-food.

    And the driver_init function is something which where currently
    just the bloody module initialization function get's called
    a seond time - and this is just plain wrong.

    If I hadn't tought about it I wouldn't be that advantegrous.
    And my testing of it did consist of the following:

    1. 2 x IDE drives of one IDE port.

    2. 1 x CD-RW on a second port - modularized.

    3. 1 x CarBus to CF adapter.

    It all worked well after the removal!



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:24    [W:3.587 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site