lkml.org 
[lkml]   [2002]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 2.5.5] do export vmalloc_to_page to modules...
On Wed, Feb 20, 2002 at 04:00:47PM +0000, Hugh Dickins wrote:
> Ingo,
>
> On Wed, 20 Feb 2002, Stelian Pop wrote:
> > The following trivial patch exports the new vmalloc_to_page primitive to
> > the modules (following mingo's modifications to, at least, the v4l drivers).
> >
> > Stelian.
> >
> > ===== kernel/ksyms.c 1.62 vs edited =====
> > --- 1.62/kernel/ksyms.c Mon Feb 18 18:09:54 2002
> > +++ edited/kernel/ksyms.c Wed Feb 20 12:08:42 2002
> > @@ -107,6 +107,7 @@
> > EXPORT_SYMBOL(kfree);
> > EXPORT_SYMBOL(vfree);
> > EXPORT_SYMBOL(__vmalloc);
> > +EXPORT_SYMBOL(vmalloc_to_page);
> > EXPORT_SYMBOL(mem_map);
> > EXPORT_SYMBOL(remap_page_range);
> > EXPORT_SYMBOL(max_mapnr);
>
> Hmm, what is this "vmalloc_to_page" and in what tree do we find it?
> Is this a case of BitKeeper users getting ahead of the game?
>
> I ask because I was preparing mail and patch to replace Arjan's
> uvirt-to-kva-2.5.5-A0 (and those parts of your highmem-2.5.5-A0).
>
> In brief, I contend that
> unsigned long uvirt_to_kva(pgd_t *pgd, unsigned long adr)
> is not appropriate or useful for mm/memory.c to provide, but
> struct page *vvirt_to_page(unsigned long vadr)
> is appropriate and useful for mm/vmalloc.c to provide.
>
> Is that what your "vmalloc_to_page" is? If so, why are you also
> marketing "uvirt_to_kva"? If not, sorry for all the confusion!

uvirt_to_kva got fixed. bad interface.
and replaced by vmalloc_to_page() which is the right one (eg returing
struct page).

Now if it should be EXPORT_SYMBOL or EXPORT_SYMBOL_GPL() I leave to Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.153 / U:3.236 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site