lkml.org 
[lkml]   [2002]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[PATCH] 2.5: further llseek cleanup (3/3)
Hi Robert,

I think the pcilynx change is wrong:

> - if (newoffs < 0 || newoffs > PCILYNX_MAX_MEMORY + 1) return
> -EINVAL;
> + if (newoffs < 0 || newoffs > PCILYNX_MAX_MEMORY + 1) {
> + lock_kernel();
^^^^^^ unlock_kernel()?
> + return -EINVAL;
> + }
>
> file->f_pos = newoffs;
^^^^^^^^^^^^^^^^^^^ where is the unlock here?
> return newoffs;

--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:18    [W:0.312 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site