lkml.org 
[lkml]   [2002]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: IDE cleanup for 2.5.4-pre3

Martin,

I asked you off line to slow down so I can fix a few issues.
I have acknowledged you ideas are good but are woefully untimely.
Obviously you have some agenada with a StartUp company because you work
for a Germnay Venture Capital firm.

Maybe it would be more useful if you bothered to feed the code via the
correct paths. Since I am going to reject it until I can review it, and
have made very clear there are some core problems to address. You can
make all kinds of fancy rewrites all day long but until the bottom
transport is finished it will still break.

Regards,

On Sat, 16 Feb 2002, Martin Dalecki wrote:

> Pavel Machek wrote:
>
> >Hi!
> >
> >>It seems bigger as it is at first glance, however if you start to read
> >>it at ide.h, the rest should
> >>be, well, obivous...
> >>
> >
> >Ouch, its *big*. You should probably start pushing it to Jens ASAP,
> >because if you'll clean up it a bit more, you'll end with really big
> >patch which rewrites whole drivers/ide... [Not that it would be a bad
> >thing.]
> >
>
> Well the atomic part of the patch is rather small if you look at it. But
> in hell unfortunately there is
> no way around to make the consequences smaller. I would be much happier
> if it could be
> done otherway around... but I see no way if one want's to preserve the
> drivers in a functional state.
>
> >My favourite cleanup would be
> >
> >struct ide_drive_s {} ide_drive_t;
> >
> >=>
> >
> >struct ide_drive {};
> >
> >and replacing all ide_drive_t with struct ide_drive...
> >
>
> That will happen.
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

Andre Hedrick
Linux Disk Certification Project Linux ATA Development

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.097 / U:24.512 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site