lkml.org 
[lkml]   [2002]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: another IDE cleanup: kill duplicated code
On Wed, 13 Feb 2002, Jens Axboe wrote:

> On Tue, Feb 12 2002, Andre Hedrick wrote:
> > On Wed, 13 Feb 2002, Jens Axboe wrote:
> >
> > > On Tue, Feb 12 2002, Andre Hedrick wrote:
> > > > I just love how the copy of a request has worked its way back into to the
> > > > code-base. :-/ I recall Linus stating it was/is a horrid mess.
> > >
> > > The copy itself is not the horrid mess, the handling of multi write is
> > > what is the horrible mess. Having a private copy to mess with is pretty
> > > much a necessity IMO if you want to handle > current_nr_sectors at the
> > > time without completing it chunk by chunk.
> >
> > Exactly, and I am about to have a valid clean solution that is short and
> > proper. Now that I have the handler working, I need to have the one walk
> > function to do the bio indexing. Also it is less than 30 lines.
>
> Those changes add yet another member to struct bio for no good reason.
> I'd much rather just do the private copy. So... ->

NO NEW STRUCT TO BIO ...
Private COPY is a given, just using it cleanly the issue.

> > Not the stuff you added as an interm fix :-/
>
> I don't consider the copy an interim fix at all. But please show your
> working handler and we can discuss it, it's pointless to debate what fix
> is the better one you are sitting on yours.

Yep but this time you get a clean solution that works.

> > You know why these changes people are pushing are wrong, because it is way
> > to early to being the compression code process.

You if any know the original TCQ of mine would scream, much less the
derivative you started off that code base. Keep that in mind, with an
expanded code thread we can isolate changes and test variation.

> The global read-ahead change is surely not what we want. The IDE
> cleanups I've seen so far look good to me.

The "read-ahead" is a NOP.

The fillin(blah, blah, blah) is!

Cheers,

Andre Hedrick
Linux Disk Certification Project Linux ATA Development

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.089 / U:0.872 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site