lkml.org 
[lkml]   [2002]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ver_linux script updates
Hello,

David Ford wrote:
> I've been working on an update to the ver_linux script and I'm looking
> for comment and help in improving the accuracy of reported information.
> The script is at http://stuph.org/ver_linux
>
> Please provide feedback on it.

o your script assumes bash as /bin/sh. Is this ok with everyone? Is
there noone running a Bourne shell only? printf and declare are not
in the standard Boune shell, IIRC.
o the script hangs when calling loadkeys, because loadkeys without
arguments waits forever. A fix is to pass "loadkeys -V" as third
argument to pv().
o if you assume bash why don't you try to convert all of the code into
bash (inline functions) instead of using awk and sed like the old code
did?
o your script indicates that one should check for "not found/error" but
this never appears, it should be "error getting version, try manually"
o the old script separated the loaded kernel modules with a space, the
new code with a '\n'
o the old code correctly detects my "kbd" version, the new not, because
you use setleds which on my machine reports: "KDGKBLED: Invalid
argument"

Why do you want to change this tool? To me it seems like an endless task
because people don't code according to standards. For example if
everyone could stick to let's say that 'progname --version' prints the
version, things would be a lot easier.

Cheers,
Roberto Nibali, ratz

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:24    [W:0.056 / U:19.856 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site