Messages in this thread Patch in this message | | | Date | Mon, 11 Feb 2002 03:29:57 +0100 | From | "Udo A. Steinberg" <> | Subject | [PATCH] 2.5.4-pre6 pci/proc.c compile fix |
| |
Hi Linus,
The attached patch fixes the following compile warning in 2.5.4-pre6:
proc.c: In function `proc_bus_pci_read': proc.c:49: warning: passing arg 1 of `PDE' discards qualifiers from pointer target type proc.c: In function `proc_bus_pci_write': proc.c:131: warning: passing arg 1 of `PDE' discards qualifiers from pointer target type
I see no reason why the two inline functions should not use const qualifier. Otherwise the caller in proc.c should be fixed.
Regards, Udo.
--- linux-2.5.4-pre-vanilla/include/linux/proc_fs.h Mon Feb 11 03:03:48 2002 +++ linux-2.5.4-pre/include/linux/proc_fs.h Mon Feb 11 03:09:50 2002 @@ -217,12 +217,12 @@ struct inode vfs_inode; }; -static inline struct proc_inode *PROC_I(struct inode *inode) +static inline struct proc_inode *PROC_I(const struct inode *inode) { return list_entry(inode, struct proc_inode, vfs_inode); } -static inline struct proc_dir_entry *PDE(struct inode *inode) +static inline struct proc_dir_entry *PDE(const struct inode *inode) { return PROC_I(inode)->pde; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |