Messages in this thread | | | Date | Thu, 05 Dec 2002 12:09:40 -0800 | From | george anzinger <> | Subject | Re: [PATCH ] POSIX clocks & timers take 15 (NOT HIGH RES) |
| |
Linus Torvalds wrote: > > Ok, finally starting to look at merging this, however: > > This must go (we already have a timespec, there's no way it should be > here in <asm/signal.h>): > > +#ifndef _STRUCT_TIMESPEC > +#define _STRUCT_TIMESPEC > +struct timespec { > + time_t tv_sec; /* seconds */ > + long tv_nsec; /* nanoseconds */ > +}; > +#endif /* _STRUCT_TIMESPEC */
OK. > > and you have things like > > + if ((flags & TIMER_ABSTIME) && > + (clock->clock_get != do_posix_clock_monotonic_gettime)) { > + }else{ > + }
A hang over from the high res code, I will remove the empty else. > > and > > +if (!p) { > +printk("in sub_remove for id=%d called with null pointer.\n", id); > +return(0); > +}
That is in there!? I will check into and fix it. > > and obviously the "nanosleep()" thing and the CLOCK_NANOSLEEP_ENTRY() > stuff has been discussed in the unrelated thread (ie it doesn't work for > alpha or other architectures).
Right! I am merging this now.
I think something went into bk5 yesterday that will require an update. I will update to 2.5.50-bk5 with the above fixes and sent it ... soon. -- George Anzinger george@mvista.com High-res-timers: http://sourceforge.net/projects/high-res-timers/ Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |