lkml.org 
[lkml]   [2002]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject7/19
    From
    There's a bug in the dm-stripe.c constructor failing top check if enough
    destinations are handed in. [Heinz Mauelshagen]
    --- diff/drivers/md/dm-stripe.c 2002-12-16 09:40:48.000000000 +0000
    +++ source/drivers/md/dm-stripe.c 2002-12-16 09:40:53.000000000 +0000
    @@ -131,6 +131,15 @@
    return -EINVAL;
    }

    + /*
    + * Do we have enough arguments for that many stripes ?
    + */
    + if (argc != (2 + 2 * stripes)) {
    + ti->error = "dm-stripe: Not enough destinations "
    + "specified";
    + return -EINVAL;
    + }
    +
    sc = alloc_context(stripes);
    if (!sc) {
    ti->error = "dm-stripe: Memory allocation for striped context "
    @@ -151,13 +160,6 @@
    * Get the stripe destinations.
    */
    for (i = 0; i < stripes; i++) {
    - if (argc < 2) {
    - ti->error = "dm-stripe: Not enough destinations "
    - "specified";
    - kfree(sc);
    - return -EINVAL;
    - }
    -
    argv += 2;

    r = get_stripe(ti, sc, i, argv);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:31    [W:0.019 / U:62.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site